Add wrapping attribute and update DataProvider method to use it

[Jim-Webfox]

No description provided.

[gemini-code-assist]

Hello @Jim-Webfox, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request introduces a new WrappingAttribute interface and an InertiaMerge attribute to allow wrapping the return value of DataProvider methods with Inertia::Merge. The DataProvider class is updated to recognize and apply these wrapping attributes.

Highlights

• Wrapping Attributes: Introduces the concept of wrapping attributes for DataProvider methods, enabling modification of the return value.
• InertiaMerge Attribute: Adds a concrete InertiaMerge attribute that uses Inertia::Merge to wrap the return value.
• DataProvider Update: Modifies the DataProvider::toArray() method to detect and apply wrapping attributes to method return values.

Changelog

Click here to see the changelog

• src/DataProvider.php
  • Added use statement for WrappingAttribute.
  • Modified toArray method to check for attributes on methods.
  • If a WrappingAttribute is found, it's instantiated and used to wrap the method's return value.
• src/WrappingAttributes/InertiaMerge.php
  • Created new InertiaMerge attribute class.
  • The InertiaMerge attribute implements the WrappingAttribute interface.
  • The __invoke method uses Inertia::Merge to wrap the data.
• src/WrappingAttributes/WrappingAttribute.php
  • Created new WrappingAttribute interface.
  • Defines the __invoke method for wrapping data.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

An attribute's embrace,
Wraps data with gentle grace,
Inertia's merge flows.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request introduces a new feature to wrap method results using attributes, which is a useful addition. The implementation is generally well-structured, but there are a few areas that could be improved for efficiency and clarity.

Summary of Findings

• Wrapping Attribute Usage: The code introduces a mechanism to wrap method results using attributes. This allows for applying transformations or integrations with other systems (like Inertia) in a declarative way. This is a good feature.
• Potential Performance Issue: The current implementation iterates through all attributes on a method, even after finding a WrappingAttribute. This could be inefficient if a method has multiple attributes and only one is intended for wrapping. Consider breaking the loop after finding the first wrapping attribute.

Merge Readiness

The code is generally well-structured and introduces a useful feature. However, the potential performance issue identified should be addressed before merging. Additionally, consider adding documentation or examples to illustrate how to use the new wrapping attribute functionality. I am unable to approve this pull request, and recommend that others review and approve this code before merging.

[gemini-code-assist]

To improve efficiency, consider breaking out of the foreach loop after finding and applying the first WrappingAttribute. This prevents unnecessary iterations if multiple attributes are present but only one is intended for wrapping.

                if (count($attributes) > 0) {
                    foreach ($attributes as $attribute) {
                        $attributeInstance = $attribute->newInstance();
                        if ($attributeInstance instanceof WrappingAttribute) {
                            return [$method->name => $attributeInstance(fn () => app()->call([$this, $method->name]))];
                        
                        }
                    }
                }

[hailwood]

We should add attributes for Defer and Lazy as well.
Also, don't forget to update the reademe.