Skip to content

Fixes GH-941 #942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2025
Merged

Fixes GH-941 #942

merged 1 commit into from
Jan 29, 2025

Conversation

pyhedgehog
Copy link
Contributor

No description provided.

@pyhedgehog
Copy link
Contributor Author

@coolaj86
When "tomorrow" will happens? ;-)

@coolaj86 coolaj86 self-requested a review January 29, 2025 22:54
coolaj86
coolaj86 approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@coolaj86 coolaj86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing this regexp is so scary (it'll break something, I'm sure)... but we'll do it!

The tab API is no longer used internally - it's been replaced by the build-classifier. But until I have time to update the tab API I suppose we might as well fix this.

@coolaj86
Copy link
Member

@coolaj86 When "tomorrow" will happens? ;-)

Today!

@coolaj86 coolaj86 merged commit 75e39c5 into webinstall:main Jan 29, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coolaj86 coolaj86 coolaj86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pyhedgehog @coolaj86