-
Notifications
You must be signed in to change notification settings - Fork 269
fix(koji): update binary path, docs #968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
By the way, sorry to be so upfront about it, but the developer experience is terrible. The Perhaps if I spent more time debugging I could fix the issue myself somehow, but that just shouldn't be expected of people wanting to test simple edits on their scripts (especially since simplicity seems to be a core goal of this project). By no means am I trying to diminish your work, webi is great, but this part is just not that great. Edit: I hope this comment didn't come of as rude, I simply projected my frustration of debugging the test script for half an hour into the comment, with no intentions of insulting anyone. |
I agree and I take no offense. "Simplicity is complicated" and I've taken some wrong turns on the way to get the project to where it is today. If you're free to schedule some time and work through the testing process together, that would be helpful to me to have the motivation to focus on it for a few hours. If so, what timezone are you in? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If koji version
worked before, I'd suggest not breaking that, as scripts may rely on it.
In general, -V
is the expected POSIX flag, --version
is the expected GNU flag, and version
is the expected subcommand (Go, Rust, Zig, Node, etc), so supporting all 3 is a good idea.
I'm going to add a little shim to this so that it doesn't break old versions.
c5e05c4
to
c0dce1a
Compare
The release process of koji has been updated a while ago, resulting in the binary not being nested in the archive anymore. Fixes cococonscious/koji#137
c0dce1a
to
a32d978
Compare
|
I'd like to, but I'm very busy in the upcoming weeks so I can't really spend any time on this. If you want to wait 1-2 months feel free to create an issue and link me in it. |
a32d978
to
3d1a751
Compare
I tested it with a few different versions pushed to main. Go ahead and test it on your end and see if it's working as you expect. |
One thing that I'm a little confused about is that it's defaulting to koji 1.4 for Linux, but 3.2 for Mac. Is the linux version marked "beta" instead of stable? Or something else that might cause the version auto detection to be overwritten? Is there anything that comes to mind for you as to why that might be? |
Hm, these are the differences from v3.2 to v1.4:
Any ideas? Perhaps your system is using musl? |
Webi prefers musl builds because they typically don't have any dependencies, whereas gnu builds are guaranteed to have dependencies which have conflicts between versions of Linux. Why drop musl builds when they're so much more reliable? |
I quite simply forgot. I'll add them to future releases of koji. |
The release process of koji has been updated a while ago, resulting in the binary not being nested in the archive anymore.
Fixes cococonscious/koji#137