Skip to content

fix(koji): update binary path, docs #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 20, 2025

Conversation

cococonscious
Copy link
Contributor

The release process of koji has been updated a while ago, resulting in the binary not being nested in the archive anymore.

Fixes cococonscious/koji#137

@cococonscious
Copy link
Contributor Author

cococonscious commented Feb 19, 2025

By the way, sorry to be so upfront about it, but the developer experience is terrible.

The _webi/test.js script isn't functional, nor helpful with debug/error messages and the usage guide is just straight up wrong (e.g. adding the --debug flag triggers the usage help error). From another issue I got the idea that I could just self host it locally real quick, but there's no guide to do so, nor any container I could quickly spin up.

Perhaps if I spent more time debugging I could fix the issue myself somehow, but that just shouldn't be expected of people wanting to test simple edits on their scripts (especially since simplicity seems to be a core goal of this project).

By no means am I trying to diminish your work, webi is great, but this part is just not that great.

Edit: I hope this comment didn't come of as rude, I simply projected my frustration of debugging the test script for half an hour into the comment, with no intentions of insulting anyone.

@coolaj86
Copy link
Member

coolaj86 commented Feb 19, 2025

By the way, sorry to be so upfront about it, but the developer experience is terrible.

I agree and I take no offense.

image
(me ^^)

"Simplicity is complicated" and I've taken some wrong turns on the way to get the project to where it is today.

If you're free to schedule some time and work through the testing process together, that would be helpful to me to have the motivation to focus on it for a few hours. If so, what timezone are you in?

Copy link
Member

@coolaj86 coolaj86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If koji version worked before, I'd suggest not breaking that, as scripts may rely on it.

In general, -V is the expected POSIX flag, --version is the expected GNU flag, and version is the expected subcommand (Go, Rust, Zig, Node, etc), so supporting all 3 is a good idea.

I'm going to add a little shim to this so that it doesn't break old versions.

The release process of koji has been updated a while ago, resulting in the binary not being nested in the archive anymore.

Fixes cococonscious/koji#137
@cococonscious
Copy link
Contributor Author

If koji version worked before, I'd suggest not breaking that, as scripts may rely on it.

In general, -V is the expected POSIX flag, --version is the expected GNU flag, and version is the expected Go subcommand, so supporting all 3 is a good idea.

I'm going to add a little shim to this so that it doesn't break old versions.

  1. The version subcommand hasn't ever existed on koji. I can add it if you want me to but I'd prefer to fix the install script first.
  2. Your fix for backwards compatibility is nice, thank you, but it's actually prior to version 3.0.0, not 1.4

@cococonscious
Copy link
Contributor Author

If you're free to schedule some time and work through the testing process together, that would be helpful to me to have the motivation to focus on it for a few hours. If so, what timezone are you in?

I'd like to, but I'm very busy in the upcoming weeks so I can't really spend any time on this. If you want to wait 1-2 months feel free to create an issue and link me in it.

@coolaj86 coolaj86 merged commit 3d1a751 into webinstall:main Feb 20, 2025
3 checks passed
@coolaj86
Copy link
Member

I tested it with a few different versions pushed to main.

Go ahead and test it on your end and see if it's working as you expect.

@coolaj86
Copy link
Member

One thing that I'm a little confused about is that it's defaulting to koji 1.4 for Linux, but 3.2 for Mac.

Is the linux version marked "beta" instead of stable? Or something else that might cause the version auto detection to be overwritten?

Is there anything that comes to mind for you as to why that might be?

@cococonscious
Copy link
Contributor Author

cococonscious commented Feb 20, 2025

Hm, these are the differences from v3.2 to v1.4:

  • Tag now contains the "v" prefix
  • "osx" is now "darwin"
  • Archive name doesn't contain version anymore
  • There's no more musl build for linux, only gnu

Any ideas? Perhaps your system is using musl?

@coolaj86
Copy link
Member

Perhaps your system is using musl

Webi prefers musl builds because they typically don't have any dependencies, whereas gnu builds are guaranteed to have dependencies which have conflicts between versions of Linux.

Why drop musl builds when they're so much more reliable?

@cococonscious
Copy link
Contributor Author

Why drop musl builds when they're so much more reliable?

I quite simply forgot. I'll add them to future releases of koji.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebInstall fails on Raspberry Pi
2 participants