NNotepad: Infer argument type for dictionary members #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend the WebNNUtil.argumentType() helper to handle option dictionary
members, to improve the user experience.
Previously, number and array literals were serialized as JS numbers
and arrays of numbers. This was great for `linear(1, {alpha: 2, beta:
3})` and `transpose(T, {permutation: [0,2,1]})`. But it meant
MLOperand dict members required passing via variables or using
identity(), e.g. `gemm(A, B, {c: identity(123)})`
Now you can just write `gemm(A, B, {c: 123})`, but `linear()` and
`transpose()` still work as before.
|
Not urgent - just a minor improvement to the sample. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the WebNNUtil.argumentType() helper to handle option dictionary members, to improve the user experience.
Previously, number and array literals were serialized as JS numbers and arrays of numbers. This was great for
linear(1, {alpha: 2, beta: 3})andtranspose(T, {permutation: [0,2,1]}). But it meant MLOperand dict members required passing via variables or using identity(), e.g.gemm(A, B, {c: identity(123)})Now you can just write
gemm(A, B, {c: 123}), butlinear()andtranspose()still work as before.