Adds assertion to check all keys exist in an array #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junaidbinfarooq
commented
Jan 3, 2023
junaidbinfarooq
commented
- Adds the assertion to assert if all the provided keys exist in the given array
+ Adds the assertion to assert if all the provided keys exist in the given array
zerkms
reviewed
Jan 3, 2023
| /** | ||
| * @psalm-pure | ||
| * | ||
| * @param array<int, int|string> $keys |
Contributor
There was a problem hiding this comment.
array<int, int|string> -> list<int|string>?
or
array<int, int|string> -> array<int|string>?
Collaborator
There was a problem hiding this comment.
Agree, it should be list<int|string>
shadowhand
requested changes
Nov 24, 2025
Collaborator
shadowhand
left a comment
shadowhand
left a comment
There was a problem hiding this comment.
I like this idea, but a couple of things:
- It needs to be rebased to current
master. - Return type needs to be added.
- The type needs to be changed.
- The mixin needs to be regenerated with
php bin/generate.php.
| /** | ||
| * @psalm-pure | ||
| * | ||
| * @param array<int, int|string> $keys |
Collaborator
There was a problem hiding this comment.
Agree, it should be list<int|string>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.