adds isStatic and isNotStatic

[peterfox]

Changes

• Adds the assertions isStatic and isNotStatic.
• Adds tests.
• Updates the readme docs.

Why

This can be useful in some libraries where you want to make sure that the end user hasn't provided a static function as an argument.

Assert::isStatic($closure, $message = '');
Assert::isNotStatic($closure, $message = '');

[zerkms]

you want to make sure that the end user hasn't provided a static function as an argument.

what would be a real life use case for this exactly? What property of a static function can break 3rd party code versus non-static function that simply does not use $this?

[peterfox]

So if you're writing an API that accepts a Closure but contextually binds it later on it will stop the code from working.

$obj = new stdClass();
$function = static function () {
    return 'foo';
};
$function->bindTo($obj);

This would then throw an exception like 'Cannot bind an instance to a static closure'.

A good example of where I've seen this happen is with Pest where you provide closures where the Closure is then bound to a different object.

There's probably less of a need for isStatic than there is isNotStatic.

[shadowhand]

@peterfox sorry for the delay here. If you'd still like to see this merged, please rebase to latest master, which is staged for version 2.0.

[peterfox]

@shadowhand thanks, having a look but might take a day or two to get myself back up to speed.

[shadowhand]

Tests are failing...

please regenerate Mixin with php bin/generate.php command in the project root

[shadowhand]

What scenario would cause ReflectionException to be thrown?

[peterfox]

Actually shouldn't happen. It would only occur if a string was passed to the ReflectionFunction constructor but that shouldn't happen as the assertions only accept callables.

[shadowhand]

@peterfox changes look good. Assuming tests pass, I'll merge and clean up.