Align Utils::suggestionList() with the reference implementation
#1075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vhenzl
force-pushed
the
align-suggestion-list
branch
from
d68c87b to
3202bc4
Compare
spawnia
requested changes
Feb 20, 2022
spawnia
approved these changes
Mar 14, 2022
Collaborator
spawnia
left a comment
spawnia
left a comment
There was a problem hiding this comment.
Nicely done. Thanks for working with me to adapt this code to idiomatic PHP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligns
Utils::suggestionList()with the current version ofsuggestionList()from the reference implementation.Adds the
LexicalDistanceclass to calculate the distance between strings. The built-inlevenshteinfunction can't be used as it doesn't support transpositions.Options with the same length are ordered lexicographically.
See #999 (comment) for context.