Create field args mapper and cache args resolution

[Warxcell]

Small enhancement/performance optimization + new feature.

We already have input parse value which turns array into something user defined, but same thing for field args' is missing.

And because this could be something expensive (for example - user might validate if args are within defined boundaries) - it doesn't make sense to call that mapper (or even the code that collects the args) more than once for same input. (For example in sub fields of iterable - args won't change in between each iterable).

Did brief test on performance optimization - it was about 15ms on ~800 calls - not something big, but I believe its good to have it - it will be beneficial even to users that doesn't use that args mapper.

[Warxcell]

Any idea why phpstan could be falling? I can't run it locally to test, because for some reason it requires php8.2 and I have php8.3 locally.

[spawnia]

Any idea why phpstan could be falling? I can't run it locally to test, because for some reason it requires php8.2 and I have php8.3 locally.

Can you not see the output in https://github.com/webonyx/graphql-php/actions/runs/10038021756/job/27739070572?pr=1587?

Error: Method GraphQL\Tests\Executor\ResolveTest::buildSchema() has parameter $testField with no value type specified in iterable type array<string, mixed>.
Error: PHPDoc tag @param for parameter $testField contains unresolvable type.

GitHub also inlines the errors for me:

[Warxcell]

Any idea why phpstan could be falling? I can't run it locally to test, because for some reason it requires php8.2 and I have php8.3 locally.

Can you not see the output in https://github.com/webonyx/graphql-php/actions/runs/10038021756/job/27739070572?pr=1587?

Error: Method GraphQL\Tests\Executor\ResolveTest::buildSchema() has parameter $testField with no value type specified in iterable type array<string, mixed>.
Error: PHPDoc tag @param for parameter $testField contains unresolvable type.

GitHub also inlines the errors for me:

I see it, just don't understand it.
Type of param is specified, why it's say it isn't?

And why same code passes check with php7.4 & 8.0 but fails with 8.1, 8.2 & 8.3?

[Warxcell]

Locally:

 php -dmemory_limit=-1 ./vendor/bin/phpstan
Note: Using configuration file /home/bozhidar_hristov/projects/graphql-php/phpstan.neon.dist.
 414/414 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%


                                                                                                                        
 [OK] No errors                                                                                                         
                                                                                                                        

🤷

[spawnia]

@Warxcell Please merge the latest changes from master, let's see if tests and static analysis pass.

[Warxcell]

Done. No idea why phpstan is failing:
Locally I have this error (which again, no idea why happens)

------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   src/Utils/SchemaExtender.php                                                                                                                                                                                                                                             
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  424    Method GraphQL\Utils\SchemaExtender::extendImplementedInterfaces() should return array<int, GraphQL\Type\Definition\InterfaceType> but returns array<int, GraphQL\Type\Definition\InterfaceType|(GraphQL\Type\Definition\NamedType&T of GraphQL\Type\Definition\Type)>.  
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 


                                                                                                                        
 [ERROR] Found 1 error                                                                                                  
                                               

[Warxcell]

Making draft, as I might seen a bug.

EDIT: It's fine - my fault on how I use it.

[spawnia]

Please add docs at https://webonyx.github.io/graphql-php/type-definitions/object-types/#field-configuration-options

[Warxcell]

I'm thinking something - maybe its better to use both $fieldDef and $fieldNode as cache key. So if

field {
   field2 <- if this is from interface, and it returns two versions of that interface - it would be called twice.
} 

It would be better I believe. Done.

[spawnia]

Thank your @Warxcell for your hard work and persistence on this!

[spawnia]

Released with https://github.com/webonyx/graphql-php/releases/tag/v15.16.0.