Skip to content

Fix: prevent TypeError when assets or modules are undefined in analyzer #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Nov 20, 2025
Merged

Fix: prevent TypeError when assets or modules are undefined in analyzer #679

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
5604cb0
Fix: prevent TypeError when assets or modules are undefined in analyzer
Srushti-33 Nov 10, 2025
2b334dd
Changelog: add entry for TypeError fix in analyzer.js (#679)
Srushti-33 Nov 10, 2025
8f1d35c
git commit --amend --author="Srushti <[email protected]>"A…
Srushti-33 Nov 10, 2025
350f184
t push origin fix-stats-object-error
Srushti-33 Nov 10, 2025
999f9b1
Address review feedback: remove standalone test and add to existing a…
Srushti-33 Nov 12, 2025
c746f51
Add minimal stats generated with webpack-cli --stats=minimal
Srushti-33 Nov 13, 2025
8a11329
Fix: use minimal-stats/stats.json in test
Srushti-33 Nov 13, 2025
89c1a94
fix: handle undefined chunks and modules in getBundleModules
Srushti-33 Nov 14, 2025
4ddb2d4
chore: remove unintended files
Srushti-33 Nov 14, 2025
ed1eebe
fix: handle minimal stats and undefined chunks/modules
Srushti-33 Nov 14, 2025
10a4d09
feat: handle undefined assets/modules in analyzer with minimal stats …
Srushti-33 Nov 18, 2025
e76fbd1
Restore back to original, minimal code change
valscion Nov 20, 2025
e743f65
Simplify test case to expect empty chart data
valscion Nov 20, 2025
d96bbfc
Merge branch 'main' into fix-stats-object-error
valscion Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/analyzer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ function getViewerData(bundleStats, bundleDir, opts) {
}

// Picking only `*.js, *.cjs or *.mjs` assets from bundle that has non-empty `chunks` array
bundleStats.assets = bundleStats.assets.filter(asset => {
bundleStats.assets = (bundleStats.assets || []).filter(asset => {
// Filter out non 'asset' type asset if type is provided (Webpack 5 add a type to indicate asset types)
if (asset.type && asset.type !== 'asset') {
return false;
Expand Down Expand Up @@ -116,7 +116,7 @@ function getViewerData(bundleStats, bundleDir, opts) {
}

// Picking modules from current bundle script
let assetModules = modules.filter(statModule => assetHasModule(statAsset, statModule));
let assetModules = (modules || []).filter(statModule => assetHasModule(statAsset, statModule));

// Adding parsed sources
if (parsedModules) {
Expand All @@ -140,7 +140,7 @@ function getViewerData(bundleStats, bundleDir, opts) {
unparsedEntryModules[0].parsedSrc = assetSources.runtimeSrc;
} else {
// If there are multiple entry points we move all of them under synthetic concatenated module.
assetModules = assetModules.filter(mod => !unparsedEntryModules.includes(mod));
assetModules = (assetModules || []).filter(mod => !unparsedEntryModules.includes(mod));
assetModules.unshift({
identifier: './entry modules',
name: './entry modules',
Expand Down