Skip to content

Replace glob with fs helpers #1454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
gameroman wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Replace glob with fs helpers #1454

gameroman wants to merge 6 commits into from

Conversation

@gameroman
Copy link
Contributor

@gameroman gameroman commented Jan 8, 2026 •
edited
Loading

Step 1 of #1447

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 8, 2026 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/knip@1454

commit: 3d582ce

@gameroman gameroman changed the title First step of #1447 Step 1 of #1447 Jan 8, 2026
@gameroman gameroman marked this pull request as ready for review January 8, 2026 22:27
@webpro webpro changed the title Step 1 of #1447 Replace glob with fs helpers Jan 9, 2026
webpro
webpro reviewed Jan 9, 2026
View reviewed changes
Copy link
Member

@webpro webpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Any chance we could use isFile in each instance? I just pushed 2d0bb0c so it has the same API as findFile.

@gameroman gameroman requested a review from webpro January 10, 2026 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@webpro webpro Awaiting requested review from webpro

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gameroman @webpro