Skip to content

lang code fixes: #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 12, 2025
Merged

lang code fixes: #834

merged 3 commits into from
May 12, 2025

Conversation

ikreymer
Copy link
Member

  • validate --lang values, fail immediately with invalid iso-639-1 country code
  • ignore --lang value when using profile, print warning that profile language takes precedence
  • fixes Validation of language codes #833

@ikreymer
lang code fixes:
f22ee8f 
- validate --lang values, fail immediately with invalid iso-639-1 country code
- ignore --lang value when using profile, print warning that profile language takes precedence
- fixes #833
@ikreymer ikreymer requested a review from tw4l May 10, 2025 05:01
tw4l
tw4l approved these changes May 12, 2025
View reviewed changes
Copy link
Member

@tw4l tw4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could use a test or two, otherwise looks good

@ikreymer ikreymer merged commit 71de8d6 into main May 12, 2025
4 checks passed
@ikreymer ikreymer deleted the lang-code-checks branch May 12, 2025 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tw4l tw4l tw4l approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validation of language codes
2 participants
@ikreymer @tw4l