optimization: normalize dedup status: treat 0 (response code not yet known) or 206 as 200… #835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to avoid fetching duplicate content when fetched through different code path
ikreymer
changed the title
tw4l
reviewed
May 12, 2025
The check happens before the fetch starts, to see if it should be skipped. Sometimes the status code is already known (if coming from browser) while other times it is not yet (when doing a full fetch call in node). I guess technically it could still fetch headers to know what status is in the latter case, but that requires more refactoring (can be done as a follow-up) |
tw4l
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids fetching duplicate content when fetched through different code path (eg. autoplay behavior calling fetch, vs video playing automatically)