Skip to content

Add option to save local/sessionStorage #856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 1, 2025
Merged

Add option to save local/sessionStorage #856

merged 2 commits into from
Jul 1, 2025

Conversation

ikreymer
Copy link
Member

If --saveStorage is set, localStorage and sessionStorage will be serialized with the WARC record for the page.
If a page redirects, track what the current page URL is and save storage as part of the page's WARC record.

Fixes #855

Note: should this be an option or enabled by default?

@ikreymer ikreymer requested a review from tw4l June 28, 2025 19:09
Copy link
Member

@tw4l tw4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would definitely keep this an opt-in feature so that people don't accidentally share WACZs that have data they don't intend to share. Otherwise looks great!

@ikreymer ikreymer merged commit 687f08b into main Jul 1, 2025
4 checks passed
@ikreymer ikreymer deleted the save-storage branch July 1, 2025 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to serialize local/sessionStorage
2 participants