Skip to content

profiles: use a fixed profile dir instead of creating a new temp dir on each load #858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 4, 2025
Merged

profiles: use a fixed profile dir instead of creating a new temp dir on each load #858

merged 2 commits into from
Jul 4, 2025

Conversation

ikreymer
Copy link
Member

@ikreymer ikreymer commented Jul 3, 2025 •
edited
Loading

  • Avoid accumulation of temp profile dirs if crawler is restarted multiple times, eg. if tmp dir is mapped to /crawls (as is in Browsertrix now), this prevents a proliferation of /crawls/tmp/profile-* dirs for each crawler restart.
  • Since profile is loaded each time, clear out existing profile dir.
  • bump to 1.6.4

@ikreymer ikreymer requested a review from emma-sg July 3, 2025 22:24
@ikreymer ikreymer merged commit 05eb101 into 1.6.4-release Jul 4, 2025
4 of 7 checks passed
@ikreymer ikreymer deleted the reuse-profile-dir branch July 4, 2025 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emma-sg emma-sg emma-sg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ikreymer @emma-sg