remove --disable-component-update flag, fixes shields not working #915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deps: update to brave 1.84.139, pptr 24.30.0 bump to 1.9.1
ikreymer
changed the title
|
brave/brave-core#30440 also introduced Passing both flags should register the components required for Shields, while excluding some other components: |
ikreymer
added a commit
that referenced
this pull request
Dec 24, 2025
Member
Author
Thanks! I missed that flag somehow when looking at that. Added both flags in #942 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should fix main cause of slow down in #913
deps: update to brave 1.84.139, pptr 24.30.0
bump to 1.9.1