Skip to content

Conversation

@ikreymer
Copy link
Member

Extends work in #547 adds Upload via @aws-sdk/lib-storage library:

  • Replaces minio client with official aws s3 client
  • Uses @aws-sdk/lib-storage for multi-part upload support

Additional testing needed:

@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​sax@​1.4.1 ⏵ 1.3.010010010085100
Addednpm/​@​aws-sdk/​lib-storage@​3.958.0991008598100
Addednpm/​@​aws-sdk/​client-s3@​3.554.09810010098100

View full report

@ikreymer
Copy link
Member Author

@mguella @wvengen @HeliosLHC can you test to see if this implementation meets your needs and works with the different S3 providers that you were using, and hopefully addresses the issues in #479 also (if its still relevant)?
At this point, it makes sense to move away from minio client libraries, given the minio is no longer being maintained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants