Draft
Conversation
- pipe cdx lines -> gzip -> hasher -> output instead of joining into one large buffer - finish cdx block if string array exceeds 10M to avoid very large cdx blocks - use native finished() function in streamFinish(), catch exceptions
Member
|
Seeing the following messages in testing: |
Member
|
Post change, now seeing a more serious error: This was also uncaught, so it stopped execution of the crawler at that point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Was initially done to address large CDX lines, but seems like a better approach overall. Not super high pri now that warcio 2.4.10 limits CDX line length)