Add-on minute checkout session setup #2944
Open
+2,012
−654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emma-sg
force-pushed
the
additional-minutes-addon-purchase
branch
2 times, most recently
from
4ee2020 to
82a6295
Compare
ikreymer
reviewed
Nov 7, 2025
emma-sg
force-pushed
the
additional-minutes-addon-purchase
branch
from
5ad2648 to
93fd027
Compare
emma-sg
force-pushed
the
additional-minutes-addon-purchase
branch
4 times, most recently
from
e583fe7 to
9fa5509
Compare
ikreymer
reviewed
Nov 18, 2025
ikreymer
reviewed
Nov 18, 2025
emma-sg
force-pushed
the
additional-minutes-addon-purchase
branch
from
9fa5509 to
febe01f
Compare
ikreymer
reviewed
Dec 4, 2025
ikreymer
reviewed
Dec 4, 2025
This comment was marked as resolved.
This comment was marked as resolved.
tw4l
reviewed
Dec 5, 2025
Member
|
Working well on dev, with a really smooth user experience. I left a few comments. I am leaning with Emma toward handling the org quota update in a transaction as the right approach here, as long as the effort isn't prohibitive (in which case #2999 seems like a good option to tide us over for now, but maybe with some more comments to help devs reading the code walk through the business logic of the aggregation). It might also be good to use this opportunity to improve our test coverage for the update quota method a little bit regardless of which path we take to test edge cases like attempting to set a quota below 0 in an update. |
- add get_checkout_url method to create checkout session for additional minutes - add /checkout/execution-minutes endpoint to handle addon purchase requests (this will need to be updated in dev/prod playbooks) - update CI workflows to remove portalUrl suffix from secret value - add test endpoint in echo server to mock checkout response
…o buy more minutes
- handle minutes purchased via SubscriptionAddMin event - use /subscriptions/add-minutes endpoint to add additional minutes
- remove context - total_price -> totalPrice - context -> paymentId - store subEventId in quota update, linking to subscription event id - org fields: don't include subEventId in org quota updates output, add OrgQuotaUpdateOut for this
emma-sg
force-pushed
the
additional-minutes-addon-purchase
branch
from
261f9b8 to
43bb583
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports purchase of additional minutes by the org admin, fixes #3051
Waiting on these PRs to be merged into this:
Refactor quota updates to use aggregation pipeline #2999