-
-
Notifications
You must be signed in to change notification settings - Fork 61
fix: Adjust page titles and badges for consistency #3053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I wonder if it would be more helpful to have the "Reviewed" archived item page header badge have the rating in the text instead of just on hover (it also appears to be just the number in the hover text rather than the appropriate text string from the review status enum).
So, e.g., instead of Reviewed, the badge could read Reviewed: Excellent or even QA Rating: Excellent to match the sort option in the archived items list.
Yes I think this looks great! I agree that there's enough context there already that it shouldn't be confusing this way. |
emma-sg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks great!





In preparation for #2874
Changes
Screenshots