-
Notifications
You must be signed in to change notification settings - Fork 971
Share link for marketplace submissions isn't communicated well #4424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hello! I'm a first-time contributor, and I'm interested in taking a look at this issue. My initial thought is to maybe create a share link with view permissions for the project by default. Could you provide more details on how to navigate this? And any tips on improving the share link would be appreciated! |
Not sure. If we create one the same way user creates them, its going to be in the list without explicitely telling user why it's there. Potentially we would need a special link that is either not shown in the share dialog or is shown but rendered in a special way with a tooltip that communicates what it is and that it can't be deleted if project is in the marketplace. Maybe it makes sense to not show it at all there. |
Hi @kof ! I was thinking about some other solutions, and I wanted to get your thoughts on some ideas below,
Additionally, I noticed that there is already a tooltip that indicates the reason for the disabled button, perhaps we can make the message more descriptive if the other options above aren't possible? Let me know what you think, thanks! |
I still think that the share link should be just generated always by default and not showed in the share dialog at all or show it so it can be copied but make it non-deleatable and renamable. |
I see, thank you for the clarification! I'll begin working on generating the share link by default when you upload a project to the marketplace, and we can decide later whether to show/hide the marketplace link in the share dialog |
@kof Hello! I started working on this feature, and I currently implemented some changes so when you click Project Settings > Marketplace > Start Review, it will create a new share link called Marketplace Link (currently visible), I was thinking that it might actually be better if the share link wasn't visible at all in the dialog so it's a little more backwards compatible with users that have already published their projects to the marketplace. I also have a few questions below and would like to know your thoughts about them,
Thank you! |
When a designer submits a project to the marketplace, they don't know they have to create a share link with view permissions for the project to have a link for viewing, otherwise the link will be disabled
The text was updated successfully, but these errors were encountered: