Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically create share link when submitting project to marketplace #4539

Closed

Conversation

natapokie
Copy link

Description

  1. What is this PR about (link the issue and add a short description)

Better communication of the Marketplace share link

  • when submitting a project to the Marketplace, a link called "Marketplace Link" will be automatically created
  • when a project is unlisted from the Marketplace, the link will be removed

Steps for reproduction

  1. Submit your project to the marketplace (Project Settings > Marketplace > Start Review)
  2. Open the share dialog -- you will see the "Marketplace Link" created automatically
    image
  3. Unlist a project from the marketplace (Project Settings > Marketplace > Start Review)
  4. Open the share dialog -- you will see the "Marketplace Link" removed

Code Review

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

…n calling submit, and remove the default share link when calling unlist
Copy link

github-actions bot commented Dec 8, 2024

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Automatically create share link when submitting project to marketplace". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat
 - fix
 - docs
 - style
 - refactor
 - perf
 - test
 - build
 - ci
 - chore
 - revert
 - experimental
Release types
  • feat - A new feature
  • fix - A bug fix
  • docs - Documentation only changes
  • style - Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • refactor - A code change that neither fixes a bug nor adds a feature
  • perf - A code change that improves performance
  • test - Adding missing tests or correcting existing tests
  • build - Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
  • ci - Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
  • chore - Other changes that don't modify src or test files
  • revert - Reverts a previous commit
  • experimental - Flagged feature

// remove the deafult share link
load({ projectId: project.id }, (data) => {
const marketplaceLink = data.find(
(currentLink) => currentLink.name === marketplaceLinkName
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

identifying an existing link by name would be very fragile

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since name is user defined, can be changed

Copy link
Member

@kof kof Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be possible to not delete anything, but instead create it once and just keep it hidden. Additionally maybe need to think about removal from marketplace too, so deletion might be still needed but when removed from marketplace approved projects

@kof
Copy link
Member

kof commented Jan 11, 2025

Closing for now as it needs more work

@kof kof closed this Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants