Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: New Icons #4590

Merged
merged 42 commits into from
Dec 24, 2024
Merged

feat: New Icons #4590

merged 42 commits into from
Dec 24, 2024
+7,125 −3,466

Conversation

kof
Copy link
Member

@kof kof commented Dec 15, 2024 •
edited
Loading

Description

  • left sidebar tab icons

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@kof kof force-pushed the icons2 branch 2 times, most recently from ad1a883 to 3fd3f9b Compare December 22, 2024 09:44
@kof kof marked this pull request as ready for review December 24, 2024 15:08
@kof kof merged commit 81b67c5 into main Dec 24, 2024
15 checks passed
@kof kof deleted the icons2 branch December 24, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrySound TrySound TrySound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kof @TrySound