build: Release 01-04-2025 #5076
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We introduced html content model which restricts how html elements can be nested into each other. Here fixed two edge cases - allow to put div into buttons, headings or any other phrasing content - allow put images into interactive elements like a > img
Co-authored-by: Oleg Isonen <[email protected]>
Fixes the issue reported in discord (https://discord.com/channels/955905230107738152/1356788803624501370/1357299346558816306) Found the spec actually allows to place button and input inside a label. So now we can generalize this logic. Also content model validation no longer prevents inserting invalid structure and only warns user is something went wrong. This will let us to never block the user with false positives and maybe even figure out the issue on their own. <img width="993" alt="Screenshot 2025-04-04 at 01 28 53" src="https://github.com/user-attachments/assets/46eb041f-2431-4140-b34e-8bc9ad757c47" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Steps for reproduction
Code Review
Before requesting a review
Before merging
.envfile