Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show proper validation error message when user inputs old path in redirect section #5082

Merged

Conversation

victorchrollo14
Copy link
Contributor

Description

fixes: #5050

fixes the validation error message when user enters old path in redirects section.

image

Steps for reproduction

  1. go to project settings.
  2. redirects tab
  3. enter a url like https://website.org in old path input field.
  4. the validation error will we shown in the tooltip.

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

Copy link
Member

@kof kof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kof kof requested a review from TrySound April 2, 2025 20:27
@TrySound TrySound merged commit 3944cbb into webstudio-is:main Apr 3, 2025
9 of 11 checks passed
@TrySound
Copy link
Member

TrySound commented Apr 3, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redirects validation error message is misleading
3 participants