-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Utilize arm runners, include TLS arm builds #423
Conversation
Did you test this PR in a separated branch? Because when I tested it, it does not run due to limitation from GitHub... that's why I suggested to use |
188ea63
to
50b5ab7
Compare
wip: build without specifying cc, print file information after build
Yes I did some tests before and got the builds passed. It appeared that they did run correctly. I would have expected that the CI doesn't start when values are used as a But I only now checked the build files locally. They don't produce arm, but x64 binaries. |
Maybe they need to be enabled for the repository as well, not just for the organization 🤔 Since you have full access, can you verify? |
Fixed. Linux ARM - |
The PR uses the arm runners to build on arm natively. This allows to include TLS builds in uploaded artifacts and to test-build examples in CI on arm.
I'd prefer finishing #422 first, as it can make resolving a conflict between the two when one of the changes is merged easier.(Resolved)Also, the mentioned followup optimization in #422's comment can make things more effective. I could make a push after the linked PR, before this one is merged.