Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize arm runners, include TLS arm builds #423

Closed
wants to merge 5 commits into from
Closed

Conversation

ttytm
Copy link
Member

@ttytm ttytm commented Jun 16, 2024

The PR uses the arm runners to build on arm natively. This allows to include TLS builds in uploaded artifacts and to test-build examples in CI on arm.


I'd prefer finishing #422 first, as it can make resolving a conflict between the two when one of the changes is merged easier. (Resolved)
Also, the mentioned followup optimization in #422's comment can make things more effective. I could make a push after the linked PR, before this one is merged.

@hassandraga
Copy link
Member

Did you test this PR in a separated branch? Because when I tested it, it does not run due to limitation from GitHub... that's why I suggested to use buildjet-2vcpu-ubuntu-2204-arm instead.

@ttytm ttytm marked this pull request as draft June 17, 2024 02:10
@ttytm ttytm force-pushed the ci/arm-runners branch 3 times, most recently from 188ea63 to 50b5ab7 Compare June 17, 2024 02:23
wip: build without specifying cc, print file information after build
@ttytm
Copy link
Member Author

ttytm commented Jun 17, 2024

Yes I did some tests before and got the builds passed. It appeared that they did run correctly. I would have expected that the CI doesn't start when values are used as a runs-on: that are not available.

But I only now checked the build files locally. They don't produce arm, but x64 binaries.

@ttytm
Copy link
Member Author

ttytm commented Jun 17, 2024

The platform info of the buildjet runner shows it's a x64:

Linux 6.5.0-1021-azure x86_64 GNU/Linux

Screenshot_20240617_043847


Neither the webui-arm-20.04 is a 20.04 when specifying it.

Screenshot_20240617_145541

@ttytm
Copy link
Member Author

ttytm commented Jun 17, 2024

Maybe they need to be enabled for the repository as well, not just for the organization 🤔

Since you have full access, can you verify?
https://github.com/webui-dev/webui/settings/actions/runners

@hassandraga
Copy link
Member

I still experimenting this GitHub paid services, so far I don't like it...
Here, at repo level, we can't add GitHub runners, only self hosted.
Here, at org level, we can add runners, but ARM ones never run.

@hassandraga
Copy link
Member

Org:

image

@hassandraga
Copy link
Member

Repo:

image

@hassandraga
Copy link
Member

buildjet-2vcpu-ubuntu-2204-arm at buildjet.com

image

@hassandraga
Copy link
Member

Fixed.

Linux ARM - webui.o: ELF 32-bit LSB relocatable, ARM, EABI5 version 1 (SYSV), not stripped
Linux ARM64 - webui.o: ELF 64-bit LSB relocatable, ARM aarch64, version 1 (SYSV), not stripped
macOS ARM64 - webui.o: Mach-O 64-bit arm64 object, flags:<|SUBSECTIONS_VIA_SYMBOLS>

@hassandraga hassandraga deleted the ci/arm-runners branch June 20, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants