Skip to content

Update to Qt6 #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 122 commits into from
Sep 20, 2024
Merged

Update to Qt6 #67

merged 122 commits into from
Sep 20, 2024

Conversation

bkmgit
Copy link
Contributor

@bkmgit bkmgit commented Sep 17, 2024

No description provided.

@bkmgit
Copy link
Contributor Author

bkmgit commented Sep 17, 2024

Addresses #66
Initial review would be helpful

@bkmgit
Copy link
Contributor Author

bkmgit commented Sep 17, 2024

There is a bug that prevents builds on Ubuntu 22.04 without unusual modifications https://bugs.launchpad.net/ubuntu/+source/qtchooser/+bug/1964763

@wedesoft
Copy link
Owner

Looks good. Please add the link to Fedora instead of replacing the link to Arch. It is failing the GitHub Workflow builds. Maybe there is an image for ubuntu-24.04? Will have a look when I get the time.

@bkmgit
Copy link
Contributor Author

bkmgit commented Sep 17, 2024

There are two links for Arch

@bkmgit
Copy link
Contributor Author

bkmgit commented Sep 17, 2024

Fedora build works. Ubuntu and Windows need updating. Build on Ubuntu 24.04 also needs an update.

@wedesoft
Copy link
Owner

Ah ok, if the Arch link was duplicate then it is fine to remove. Sorry

@wedesoft
Copy link
Owner

Maybe you can use pkgconfig (PKG_CHECK_MODULES) to find the Qt6 libraries. I haven't checked whether the Windows MinGW packages have pkgconfig files though. I haven't figured out yet how uic, rcc, and qtchooser works.

@wedesoft
Copy link
Owner

Hi, can you merge bkmgit#4 ? I think then it is ready to merge.

Fixed builds for Appimage and Debian package
@wedesoft wedesoft merged commit ecbdba5 into wedesoft:master Sep 20, 2024
3 checks passed
@wedesoft
Copy link
Owner

Thanks! Great work!

@bkmgit
Copy link
Contributor Author

bkmgit commented Sep 20, 2024

Welcome, thanks for the fast feedback.

@bkmgit bkmgit deleted the qt6 branch September 20, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants