-
Notifications
You must be signed in to change notification settings - Fork 214
Fix #1064: Auto log sample train/val images at training start (with tests) #1067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This is the one from Cursor? It does have some "tells" - for some reason Claude seems to really like mocking in unit tests (and it loves to make long test suites). I had to make a rule to discourage that. Can the bot respond to PR comments on GitHub? It would be great if we could feedback/review issues and have it fix stuff automatically. |
ce5c09a
to
22276eb
Compare
Waiting on #1079 to see if there are rebase conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but the tests could use some changes
…he predict_dataloader
6dd87ba
to
16ce0a4
Compare
@henrykironde this should be ready, passes locally. |
Description
This PR implements automatic logging of sample images from training and validation datasets at the start of training, as requested in #1064.
Changes
Implementation (
src/deepforest/main.py
)on_train_start
hook that:visualize.plot_annotations()
to create annotated imagesTests (
tests/test_on_train_start.py
)Implementation Details
log_image
methodTesting
Run the new tests with:
The implementation will automatically log images when training starts. Users will see sample images in their experiment tracking tool of choice.
Fixes #1064