Added public API to support BIP32-Ed25519 style keys. #1278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The added API functions use existing internal functionality i.e., no new cryptographic functionality was added. BIP32-Ed25519 keys are used for hierarchical-deterministic (HD) wallets and are defined in the paper "BIP32-Ed25519 Hierarchical Deterministic Keys over a Non-linear Keyspace" by Khovratovich and Law.
Fix spurious assert (GH weidai11#1279)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added public APIs to the Ed25519 Donna code that may be used to support Extended Ed25519 keys, i.e., BIP32-Ed25519 keys. BIP32-Ed25519 keys are used for hierarchical-deterministic (HD) wallets and are defined in the paper "BIP32-Ed25519 Hierarchical Deterministic Keys over a Non-linear Keyspace" by Khovratovich and Law. https://raw.githubusercontent.com/input-output-hk/adrestia/master/docs/static/Ed25519_BIP.pdf
The added API functions use existing internal functionality i.e., no new cryptographic functionality was added. Test code was added to validat7.cpp.