Create bindings for rpm.
#1281
Open
Create bindings for rpm.
#1281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This export list follows an invariant that each module exports all their
definitions and types as well as re-exports underlying newtype
constructors. This is needed to workaround the FFI compilation issue
where GHC requires all constructors in scope.
NOTE: This almost solves the problem mentioned above. There's one corner
case we didn't consider which is the fact that this is possible:
```hs
newtype A = A { un_A :: Other.Module.A }
```
RPM does this, in fact... which means we can't really export the two A's
in the same module :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1230 .
Currently blocked on #1282