Reorganized the golden tests #1295
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Reorganized `examples/golden/` into 11 subdirectories: * `types/` - Type system tests (primitives, structs, unions, enums, typedefs) * `functions/` - Function declarations, callbacks, attributes * `arrays/` - Array tests * `macros/` - C preprocessor macro tests * `declarations/` - Scoping, redeclaration, linkage * `attributes/` - GCC/Clang attributes * `program-analysis/` - Slicing, selection, reparsing * `documentation/` - Doxygen, pragmas * `edge-cases/` - UTF-8, asm, special names * `binding-specs/` - Binding specification tests * `globals/` - Global variable tests * `manual/` - Manual examples (already existed)
bolt12
commented
Nov 18, 2025
Collaborator
Author
There was a problem hiding this comment.
Move this to attributes.
bolt12
commented
Nov 18, 2025
Collaborator
Author
There was a problem hiding this comment.
Move this to macros folder.
bolt12
commented
Nov 18, 2025
Collaborator
Author
There was a problem hiding this comment.
In the types folder, further categorize the files: structs, enums, bool, etc..
edsko
approved these changes
Nov 18, 2025
Collaborator
edsko
left a comment
edsko
left a comment
There was a problem hiding this comment.
Now you're just showing off 🙄
bolt12
commented
Nov 18, 2025
|
|
||
| -- | ||
| -- Clang diagnostics | ||
| -- | ||
|
|
||
| , testDiagnostic "attributes" $ \diag -> | ||
| , testDiagnostic "attributes/attributes" $ \diag -> |
Collaborator
Author
There was a problem hiding this comment.
Have a global test list that is sorted by test name. In order to do that, associate these tests (testDiagnostic, e.g.) to variable names and add them to a list.
Collaborator
Author
There was a problem hiding this comment.
make them top level function definitions instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #755
examples/golden/into 11 subdirectories:types/- Type system tests (primitives, structs, unions, enums, typedefs)functions/- Function declarations, callbacks, attributesarrays/- Array testsmacros/- C preprocessor macro testsdeclarations/- Scoping, redeclaration, linkageattributes/- GCC/Clang attributesprogram-analysis/- Slicing, selection, reparsingdocumentation/- Doxygen, pragmasedge-cases/- UTF-8, asm, special namesbinding-specs/- Binding specification testsglobals/- Global variable testsmanual/- Manual examples (already existed)