fix issues/7796 #7797
Open
fix issues/7796 #7797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 7, 2025 15:53
There was a problem hiding this comment.
Pull Request Overview
This PR addresses bug fix #7796 by modifying the sort functionality to improve how data is ordered, including handling grouped data in bootstrap-table. Key changes include:
- Refactoring the sort function in src/utils/index.js to use a new signature and in-place array sorting.
- Updating initSort in src/bootstrap-table.js to handle custom sorting and grouping logic.
- Implementing grouping of data items when groupBy is enabled.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/utils/index.js | Refactored sort method parameters and logic. |
| src/bootstrap-table.js | Updated initSort to support groupBy and custom sorting. |
Comments suppressed due to low confidence (1)
src/utils/index.js:519
- [nitpick] Consider avoiding reassigning the 'name' parameter directly; assign header.sortNames[index] to a new variable to improve clarity in the sort logic.
if (header.sortNames[index]) {
djhvscf
requested changes
Apr 26, 2025
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes bug #7796 by refactoring the sort functionality and introducing new handling for grouped data scenarios. Key changes include:
- Refactored the sort method in src/utils/index.js to sort the entire data array and use updated parameters.
- Modified initSort in src/bootstrap-table.js to support groupBy sorting when a groupBy field is provided.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/utils/index.js | Refactored the sort function to operate on the full data set and update comparison logic. |
| src/bootstrap-table.js | Updated sort function calls and added branch handling for grouped data sorting. |
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔Type of Request
🔗Resolves an issue?
Fix #7796
📝Changelog
💡Example(s)?
before: https://live.bootstrap-table.com/code/EgorTrutnev/18772
after: https://live.bootstrap-table.com/code/EgorTrutnev/18776
☑️Self Check before Merge