Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor announcements #16

Merged
merged 3 commits into from
Aug 29, 2023
Merged

Refactor announcements #16

merged 3 commits into from
Aug 29, 2023

Conversation

wesker-albert
Copy link
Owner

@wesker-albert wesker-albert commented Aug 29, 2023 •
edited
Loading

  • remove Announcement as standalone model
  • add send_local_announcement method to Output
  • rename self.send Action prop to self.output
  • rename a handful of Output methods to be more descriptive

Closes #15

@github-actions
Copy link

Package Line Rate Branch Rate Health
. 61% 42% ➖
actions 96% 75% ✔
actions.commands 31% 23% ❌
actions.scheduled 0% 0% ❌
events 60% 46% ➖
models.data 97% 100% ✔
models.object 100% 100% ✔
resources 100% 98% ✔
Summary 56% (583 / 1041) 46% (163 / 355) ❌

@wesker-albert wesker-albert merged commit 7ce0630 into master Aug 29, 2023
1 check passed
@wesker-albert wesker-albert deleted the refactor-announcements branch August 29, 2023 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move Announcement to Output class
1 participant
@wesker-albert