Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More OOP Doors and Room Models #18

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Conversation

wesker-albert
Copy link
Owner

I realized there were some computed properties and methods living in the Rooms and Doors resources, that from an object-oriented stance, would probably better be moved into the Door and Room models themselves.

@github-actions
Copy link

Package Line Rate Branch Rate Health
. 61% 42%
actions 96% 75%
actions.commands 31% 23%
actions.scheduled 0% 0%
events 60% 46%
models 100% 97%
models.data 97% 100%
resources 100% 100%
Summary 56% (580 / 1038) 46% (163 / 355)

@wesker-albert wesker-albert merged commit 642e041 into master Aug 29, 2023
1 check passed
@wesker-albert wesker-albert deleted the more-oop-door-and-room branch August 29, 2023 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant