-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: format abi item fallback formatting #259
fix: format abi item fallback formatting #259
Conversation
🦋 Changeset detectedLatest commit: 7bc14de The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Looks good to me but @tmm should have the final say on this |
59ae8ba
to
e5cdc14
Compare
…format-abi-item-fallback-formatting
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #259 +/- ##
=======================================
Coverage 99.85% 99.85%
=======================================
Files 26 26
Lines 6103 6108 +5
Branches 186 188 +2
=======================================
+ Hits 6094 6099 +5
Misses 8 8
Partials 1 1 ☔ View full report in Codecov by Sentry. |
fixes #253
As in the issue description, there were changes in the #229 for
parseAbiItem
, but there wasn't a corresponding change made for theformatAbiItem
. This PR fixes that.Also, I spotted that
FallbackSignature
type was only acceptingfallback() external
, and notfallback() external payable
, which it should have, so I fixed that as it was a change related to the issue.PR-Codex overview
This PR focuses on enhancing the formatting of
fallback
functions in theformatAbiItem
utility, ensuring that the output accurately reflects thestateMutability
of the ABI items.Detailed summary
expected
values in tests to includeexternal
forfallback
functions.formatAbiItem
function to returnfallback() external
andfallback() external payable
based onstateMutability
.