Skip to content

Feat: Use forgit show in stash_show enter #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

carlfriedrich
Copy link
Collaborator

Instead of using git stash show in the enter binding of the stash_show command, use forgit show. This allows forgit to show the stash in the same interactive way it shows other commits (e.g. on forgit log), with the same context and formatting options.

Check list

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation

Description

Type of change

  • Bug fix
  • New feature
  • Refactor
  • Breaking change
  • Documentation change

Test environment

  • Shell
    • bash
    • zsh
    • fish
  • OS
    • Linux
    • Mac OS X
    • Windows
    • Others:

@carlfriedrich carlfriedrich requested review from Copilot and sandr01d July 2, 2025 15:41
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@carlfriedrich carlfriedrich requested review from wfxr and cjappl July 2, 2025 15:41
Copy link
Collaborator

@sandr01d sandr01d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice improvement! Was considering adding something like this just recently. Just two question from my side.

@carlfriedrich carlfriedrich force-pushed the use-forgit-show-in-stash-show-enter branch 4 times, most recently from 4bb88dd to 79089bd Compare July 14, 2025 18:11
Copy link
Collaborator

@sandr01d sandr01d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update again, looks good to me now.

carlfriedrich added a commit to carlfriedrich/forgit that referenced this pull request Jul 15, 2025
Feat: Use forgit show in stash_show enter

Instead of using `git stash show` in the `enter` binding of the
`stash_show` command, use `forgit show`. This allows forgit to show the
stash in the same interactive way it shows other commits (e.g. on
`forgit log`), with the same context and formatting options.
Instead of using `git stash show` in the `enter` binding of the
`stash_show` command, use `forgit show`. This allows forgit to show the
stash in the same interactive way it shows other commits (e.g. on
`forgit log`), with the same context and formatting options.
@carlfriedrich carlfriedrich force-pushed the use-forgit-show-in-stash-show-enter branch from f6f9c3b to 8a0dd10 Compare July 15, 2025 04:35
@carlfriedrich carlfriedrich merged commit c0df9a5 into wfxr:main Jul 15, 2025
3 checks passed
carlfriedrich added a commit that referenced this pull request Jul 15, 2025
Instead of using `git stash show` in the `enter` binding of the
`stash_show` command, use `forgit show`. This allows forgit to show the
stash in the same interactive way it shows other commits (e.g. on
`forgit log`), with the same context and formatting options.
@carlfriedrich carlfriedrich deleted the use-forgit-show-in-stash-show-enter branch July 15, 2025 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants