Blob #71
Blob #71
Conversation
| throw new Error('Invalid blob') | ||
| } | ||
|
|
||
| static fromString(value: string) { |
There was a problem hiding this comment.
This needs to handle the invalid base64 padding nodeos outputs
There was a problem hiding this comment.
I think I have tests ensuring the invalid stuff works here: 1cd6b9b
src/chain/blob.ts
Outdated
| } | ||
|
|
||
| static fromString(value: string) { | ||
| return new this(new Uint8Array(Buffer.from(value, 'base64'))) |
There was a problem hiding this comment.
Didn't catch this first time around but you cannot use Buffer in core, it's not available outside of node.js. You'll have to use atob and btoa (see https://developer.mozilla.org/en-US/docs/Glossary/Base64)
There was a problem hiding this comment.
Good catch. I originally swapped to a buffer because VSCode was complaining atob was deprecated 😅
New snag... atob and btoa aren't available in nodejs 14, so our tests against that version are failing. I added back some checks to see if Buffer exists, and if so, use it.
src/chain/blob.ts
Outdated
| } | ||
|
|
||
| get base64String(): string { | ||
| return Buffer.from(this.array).toString('base64') |
src/chain/blob.ts
Outdated
|
|
||
| /** | ||
| * Create a new Bytes instance. | ||
| * @note Make sure to take a [[copy]] before mutating the bytes as the underlying source is not copied here. |
There was a problem hiding this comment.
Docstring says Bytes and references non existent method
There was a problem hiding this comment.
Bytes is where I copied the class structure from instead of writing it from scratch... my sloppy copy/pasta. Whoops 😅
No description provided.