APIClient rework #80
Closed
APIClient rework #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removing api definitions * Testing extending APIClient * Exporting as BaseAPIClient now * Fixing tests * Update package.json
* Caching ABI in Action for future use * Added `.decoded` method to action to automatically decode * Disabled failing tests These tests don't make much sense to me. The variant being passed in as action data isn't even valid as far as I can tell. * Fixed type selection for generated action * Reimplemented tests for variant in more sane way * Removed string casting, wasn't needed
Merged
aaroncox
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a combination of:
Caching ABI in Action for future use #69(already merged, 0.9.1)This will be published as
0.10.0.