Support symbol of value 0 #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaroncox
approved these changes
Jan 20, 2024
|
Sorry for the delay - and thanks for the PR! I've been chatting with the team in Slack about this change, and there were only a few nitpicky things we can quickly correct. |
|
This is now released as wharfkit/antelope v1.0.5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of Wharfkit doesn't support the valid EOSIO
symbolof zero value. While the EOSIOassettype (unfortunately) doesn't support this symbol value the EOSIOsymboltype indeed does. Symbols of value zero are useful to encode NFT assets according to the AtomicAssets standard.This PR adds support for symbols of zero value encoded by the symbol string
"0,".