Performing a transaction #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a test showing how we'd pass the data to a
session.transactcall.Now that the contract no longer has a
contract.callmethod, we lost the one place where we could pass in the ABI automatically for the developer trying to perform a transaction.I'm trying to figure out the best way to add this functionality back in.
One idea I had: Could we have a
ContractActionwhich extendsAction, that is the same thing as anActionexcept with aContractsaved to it? If thecontract.action('transfer')call returned one of these ContractAction instances and that's what was passed to the session kit, the session kit could just extract the ABI from the Contract automatically duringtransact.