New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support opening dialog modals without automatic closing behaviour #10593

Closed

lucacasonato wants to merge 5 commits into whatwg:main from lucacasonato:no_auto_close_modal

Member

lucacasonato commented Aug 30, 2024 •

edited by pr-preview bot

Loading

Closes #10592

At least two implementers are interested (and none opposed):
- …
- …
Tests are written and can be reviewed and commented upon at:
- …
Implementation bugs are filed:
- Chromium: …
- Gecko: …
- WebKit: …
- Deno (only for timers, structured clone, base64 utils, channel messaging, module resolution, web workers, and web storage): …
- Node.js (only for timers, structured clone, base64 utils, channel messaging, and module resolution): …
MDN issue is filed: …
The top of this comment includes a clear commit message to use.

(See WHATWG Working Mode: Changes for more details.)

/interactive-elements.html ( diff )

lucacasonato added 5 commits

August 30, 2024 17:56


          Support opening dialog modals without automatic closing behaviour

5b5761e

fix

57f196f


          another fix

4450a68

fix

5eadded


          and one more

lucacasonato mentioned this pull request

Support disabling CloseWatcher integration in <dialog> #10592

Closed

domenic added the topic: dialog label

lukewarlow closed this

Member

lukewarlow commented Mar 5, 2025

Closing as this is now handled by the new closedby attribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels