-
Notifications
You must be signed in to change notification settings - Fork 2.9k
For #script-closable, clarify when a browsing context is created by script #11208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vinhill
wants to merge
3
commits into
whatwg:main
Choose a base branch
from
vinhill:issue1866
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -91772,11 +91772,19 @@ dictionary <dfn dictionary>WindowPostMessageOptions</dfn> : <span>StructuredSeri | |||||
</li> | ||||||
</ol> | ||||||
|
||||||
<p>A <span>navigable</span> is <dfn>script-closable</dfn> if its <span data-x="nav-bc">active | ||||||
browsing context</span> is an <span>auxiliary browsing context</span> that was created by a | ||||||
script (as opposed to by an action of the user), or if it is a <span>top-level traversable</span> | ||||||
whose <span data-x="tn-session-history-entries">session history entries</span>'s <span | ||||||
data-x="list size">size</span> is 1.</p> | ||||||
<p>A <span>navigable</span> is <dfn>script-closable</dfn> if it is a | ||||||
<span>top-level traversable</span>, and any of the following is true:</p> | ||||||
<ul> | ||||||
<li>it <span>is created by web content</span>; or</li> | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
You also need to fix the indentation below. |
||||||
<li>its <span data-x="tn-session-history-entries">session history entries</span>'s | ||||||
<span data-x="list size">size</span> is 1.</li> | ||||||
</ul> | ||||||
|
||||||
<!-- | ||||||
https://source.chromium.org/chromium/chromium/src/+/b20d6a654f6891ed49373d9f535d8618ded1e2e2 | ||||||
The session history check is a special case for one-off windows that need to open other windows | ||||||
and then dispose of themselves. This use case might not be necessary anymore. | ||||||
--> | ||||||
|
||||||
<p>The <dfn attribute for="Window"><code data-x="dom-window-closed">closed</code></dfn> getter | ||||||
steps are to return true if <span>this</span>'s <span data-x="window bc">browsing context</span> | ||||||
|
@@ -98494,6 +98502,8 @@ interface <dfn interface>NotRestoredReasons</dfn> { | |||||
<p>See the <a href="#page-visibility">page visibility</a> section for the requirements on this | ||||||
item.</p> | ||||||
</li> | ||||||
|
||||||
<li><p>An <dfn>is created by web content</dfn> boolean, initially false.</p></li> | ||||||
</ul> | ||||||
|
||||||
<p>To get the <dfn data-x="nav-traversable" export for="navigable">traversable navigable</dfn> of | ||||||
|
@@ -99480,6 +99490,9 @@ interface <dfn interface>NotRestoredReasons</dfn> { | |||||
contexts flag</span> is set, then all the flags that are set in <var>sandboxingFlagSet</var> | ||||||
must be set in <var>chosen</var>'s <span data-x="nav-bc">active browsing context</span>'s | ||||||
<span>popup sandboxing flag set</span>.</p></li> | ||||||
|
||||||
<li><p>Set <var>targetNavigable</var>'s <span>is created by web content</span> to true.</p> | ||||||
</li> | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This needs to stick to the |
||||||
</ol> | ||||||
|
||||||
<p class="note">If the newly created <span>navigable</span> <var>chosen</var> is immediately | ||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Newline before the
<ul>
.