-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Use the value attribute for color update if dirty value flag is false #12065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Do I now need to do something to trigger preview, or the bot is misbehaving? Hmm. (#12069 isn't getting preview either, so not just this one) |
annevk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The wording of that step feels a tad ambiguous. Perhaps it's better to make it two steps?
I made it two paragraphs in one step, as it seems it's sufficiently common in HTML to do so. There are a few instances of separate-step usage too, so either way is okay for me but I thought this could feel a bit more natural. |
|
It seems this fails on CI. Modern style doesn't do initialization of a variable twice so that needs to be done differently. |
You mean merge it back? |
Fixes #12057
(See WHATWG Working Mode: Changes for more details.)