Skip to content

New variants.json parser and priority support #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 7, 2025

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented May 6, 2025

  1. Add a new variants.json parser based on KeyTrackingValidator.
  2. Replace validate_variants_json() and unpack_variants_json().
  3. Account for variant priorities from variants.json in get_variant_hashes_by_priority().

mgorny added 4 commits May 6, 2025 18:59
Implement a complete `VariantsJson` parser based
on `KeyTrackingValidator`, and replace `validate_variants_json()`
and `unpack_variants_json()` with it.
@mgorny mgorny requested a review from DEKHTIARJonathan May 6, 2025 17:59
Copy link
Member

@DEKHTIARJonathan DEKHTIARJonathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DEKHTIARJonathan DEKHTIARJonathan merged commit 5581ce4 into dev May 7, 2025
44 checks passed
@DEKHTIARJonathan DEKHTIARJonathan deleted the variants-json-prio branch May 7, 2025 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants