Skip to content

Fix CI for make-variant and add longer option support #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 9, 2025
Merged

Fix CI for make-variant and add longer option support #88

merged 3 commits into from
May 9, 2025

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented May 9, 2025

  1. Fix validation of wrong value in make-variant.
  2. Fix type hints to get green CI.
  3. Support longer options (matching the keys) in addition to the contractions.

@mgorny mgorny requested a review from DEKHTIARJonathan May 9, 2025 13:04
DEKHTIARJonathan
DEKHTIARJonathan reviewed May 9, 2025
View reviewed changes
DEKHTIARJonathan
DEKHTIARJonathan requested changes May 9, 2025
View reviewed changes
mgorny added 3 commits May 9, 2025 15:28
@mgorny
make-variant: Use longer option names for better compatibility
5ce8db2 
Use longer option names to make them slightly more predictable.  Given
that `argparse` accept any unambiguous contraction of the arguments,
the previous shorter options still work, as well as other contractions
such as `--provider-require`.
@mgorny
make-variant: Fix type hint
f713017
@mgorny
make-variant: Fix data type for priority lists
c6fa2af
@mgorny mgorny force-pushed the make-variant-fix branch from 7aa9f5c to c6fa2af Compare May 9, 2025 13:45
@mgorny mgorny changed the base branch from main to dev May 9, 2025 13:45
@DEKHTIARJonathan DEKHTIARJonathan merged commit 1ebb6f1 into dev May 9, 2025
47 checks passed
@DEKHTIARJonathan DEKHTIARJonathan deleted the make-variant-fix branch May 9, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DEKHTIARJonathan DEKHTIARJonathan DEKHTIARJonathan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgorny @DEKHTIARJonathan