use registry for defining viewer choices #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iisakkirotko
approved these changes
Nov 11, 2024
There was a problem hiding this comment.
Hey @kecnry!
The PR looks good. If you can rebase it onto master, I'll merge it. Let me know if you'd rather I rebase it!
kecnry
commented
Nov 11, 2024
There was a problem hiding this comment.
Hi @iisakkirotko! I rebased locally but don't seem to have permissions to force push. The conflicts were quite straightforward though (mainly updating to keep the new grid layout changes from #11) if you'd rather just rebase on your end.
Comment on lines
96
to
103
| except ValueError as error: | ||
| error_message.set(str(error)) | ||
| show_error.set(True) | ||
| return |
There was a problem hiding this comment.
if this is still useful, the entire getattr(app, ...) line could be wrapped in this to keep it for all viewers.
iisakkirotko
force-pushed
the
viewers-from-registry
branch
from
9f5ee6e to
21c5e46
Compare
iisakkirotko
force-pushed
the
viewers-from-registry
branch
from
21c5e46 to
4902df2
Compare
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR swaps out the manual definitions of individual viewers with iterating through the glue registry. Note that: