Expand literals by default #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpluscode
commented
Jan 12, 2017
| else | ||
| { | ||
| var valueString = JsonConvert.ToString(value); | ||
| writer.WriteValue(valueString.Trim('"')); // for the weirdest of reasons, DateTime is double-quoted |
Contributor
Author
There was a problem hiding this comment.
@asbjornu JsonConvert produces quoted DateTime like "2016-01-03T00:00:00". any idea why this is happening?
There was a problem hiding this comment.
Hm, that's weird. We do quite an extensive customisation of the JSON serialisation in Pomona, please have a look at that if you dare. 😄 I can give it a whack when time allows, which I won't have for a few weeks. 😕
Contributor
Author
There was a problem hiding this comment.
Uh, it's just me being foolish. The date is in quotes because that is a date is represented in JSON as string. Numbers aren't so they aren't in quotes. Same with bool
Current coverage is 89.09% (diff: 88.00%)@@ master #8 diff @@
==========================================
Files 32 33 +1
Lines 386 431 +45
Methods 56 78 +22
Messages 0 0
Branches 59 65 +6
==========================================
+ Hits 345 384 +39
- Misses 29 31 +2
- Partials 12 16 +4
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3
fixes #9