-
-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log remaining instruments via Metrics Platform #4117
base: main
Are you sure you want to change the base?
Log remaining instruments via Metrics Platform #4117
Conversation
hi @dbrant @sharvaniharan @cooltey -- Q re: 2 instruments that have config but code does not seem to exist:
I didn't include the two above in this PR even tho their corresponding tables do exist in Hive (23 rows in Just flagging this for your team -- should their configs be removed? |
also, apologies that this is a rather big change set -- as I was making changes, it seemed like some of the same files were being touched so i thought doing it in one go might be easier to reconcile if it's helpful, i can break it up into smaller PRs |
After verifying data coming thru in a recent pre-prod beta release, this PR proposes to submit events for the remaining Android instruments (currently submitted via Modern Event Platform) via Metrics Platform.
The following instruments are included for Metrics Platform integration:
Some new MP classes aim to consolidate a few of the above instruments.
If it is preferred to keep naming conventions 1:1, I can adjust accordingly.
Note: these changes are purely additive - no changes should occur with current event logging.
Bug: T330355