Update fromLegacyString method #4604
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbrant
requested changes
Apr 17, 2024
| @@ -190,7 +193,7 @@ enum class Namespace(private val code: Int) : EnumCode { | |||
| return if (UserTalkAliasData.valueFor(wiki.languageCode).equals(name, true) || | |||
| UserTalkAliasData.valueFor(AppLanguageLookUpTable.FALLBACK_LANGUAGE_CODE).equals(name, true)) { | |||
| USER_TALK | |||
| } else MAIN | |||
| } else entries.firstOrNull { it.name.equals(name, true) } ?: MAIN | |||
There was a problem hiding this comment.
This will only work for English. All namespaces have different localized names on each language wiki.
I think a better long-term solution will be to get rid of fromLegacyString() entirely, and have individual functions for isTalk(), isUser(), etc. and eliminate all the places where we attempt to check for namespace() == MAIN
There was a problem hiding this comment.
...and then we could also remove >100 of the actual Namespace enum definitions that we don't actually use anywhere, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namespace.fromLegacyString()and try to find the closest namespace from the entries.PageSummary.getPageTitle()for a proper namespacePageSumary.getPageTitle()forLinkPreviewViewModel.ktPending discussion:
entries?LinkPreviewDialogfor pages in all namespaces?