-
-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refining Espresso test #5086
Merged
Merged
Refining Espresso test #5086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/src/androidTest/java/org/wikipedia/main/SmokeTests.kt
- adds TestSuite
- adds function that scrolls view to screen if not visible and clicks - adds scrollToPosition for feedView RecyclerView
…ot pattern - more test codes - removes unused codes
- code fixes
Williamrai
added
Ready to merge
PR passed design signoff and ready to be merged.
and removed
WIP
Work in progress
labels
Nov 12, 2024
dbrant
requested changes
Nov 13, 2024
dbrant
approved these changes
Nov 14, 2024
🎉 A solid foundation for the future of our instrumented tests! |
cooltey
added a commit
that referenced
this pull request
Nov 14, 2024
…tions-dashboard * contributions-dashboard-design: Refining Espresso test (#5086) Localisation updates from https://translatewiki.net. (#5120) Refine the isDonor preference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
This refines the espresso smoke test. Introduces Robot pattern which separates the test into different classes based on specific screen or utility.
Why is this needed?
This is needed so that we can
Phabricator:
https://phabricator.wikimedia.org/T358021