Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refining Espresso test #5086

Merged
merged 18 commits into from
Nov 14, 2024
Merged

Refining Espresso test #5086

merged 18 commits into from
Nov 14, 2024

Conversation

Williamrai
Copy link
Collaborator

What does this do?

This refines the espresso smoke test. Introduces Robot pattern which separates the test into different classes based on specific screen or utility.

Why is this needed?

This is needed so that we can

  1. improve code organization
  2. improve test readability
  3. developers can update and add test code easily
  4. developers can compose test easily

Phabricator:
https://phabricator.wikimedia.org/T358021

@Williamrai Williamrai added the WIP Work in progress label Nov 4, 2024
# Conflicts:
#	app/src/androidTest/java/org/wikipedia/main/SmokeTests.kt
- adds function that scrolls view to screen if not visible and clicks
- adds scrollToPosition for feedView RecyclerView
…ot pattern

- more test codes
- removes unused codes
@Williamrai Williamrai added Ready to merge PR passed design signoff and ready to be merged. and removed WIP Work in progress labels Nov 12, 2024
@dbrant
Copy link
Member

dbrant commented Nov 14, 2024

🎉 A solid foundation for the future of our instrumented tests!

@dbrant dbrant merged commit c46dc78 into main Nov 14, 2024
1 check passed
@dbrant dbrant deleted the espresso-test branch November 14, 2024 14:06
cooltey added a commit that referenced this pull request Nov 14, 2024
…tions-dashboard

* contributions-dashboard-design:
  Refining Espresso test (#5086)
  Localisation updates from https://translatewiki.net. (#5120)
  Refine the isDonor preference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge PR passed design signoff and ready to be merged.
Development

Successfully merging this pull request may close these issues.

3 participants