Follow-up: YiR entry dialog code optimization #5479
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
A follow-up PR of #5465 that does the following optimization:
EntryDialog
instead of a plainDialog
.BottomSheetScaffold
toYearInReviewEntryDialogScreen
, since there might be another bottomsheet that exists in the YiR package, and also for easier access.entry_dialog
in them.centerCrop
.@voyagerfan Please help review, and we can discuss this in our 1:1 for you to have a better picture of this PR.