Skip to content

Follow-up: YiR entry dialog code optimization #5479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025

Conversation

cooltey
Copy link
Collaborator

@cooltey cooltey commented Apr 16, 2025

What does this do?

A follow-up PR of #5465 that does the following optimization:

  • Renames classes to EntryDialog instead of a plain Dialog.
  • Renames BottomSheetScaffold to YearInReviewEntryDialogScreen, since there might be another bottomsheet that exists in the YiR package, and also for easier access.
  • Renames the string resources with entry_dialog in them.
  • Optimizes the scrolling experience.
  • Optimizes the padding for title, body text, and the image - the current image is cut because of the centerCrop.

@voyagerfan Please help review, and we can discuss this in our 1:1 for you to have a better picture of this PR.

@cooltey cooltey added the Minor Minor stuff label Apr 16, 2025
Copy link
Contributor

@voyagerfan voyagerfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Cooltey, the naming convention you're using looks good - I'll be mindful that as well as the padding values in the next PR.

@voyagerfan voyagerfan merged commit 6a1c787 into yearInReview_design Apr 17, 2025
2 checks passed
@voyagerfan voyagerfan deleted the yir-followup-entrydialog branch April 17, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Minor Minor stuff
Development

Successfully merging this pull request may close these issues.

2 participants